feat(review): make the PR-review skill the default reviewer#675
Merged
Conversation
Route PR code review through the `pr-management-code-review` skill — which already drafts findings as inline comments presented individually for accept/skip — rather than an ad-hoc pass or a generic review command. - AGENTS.md: dogfood the skill for reviews in this repo (new "Reviewing pull requests" note under Reusable skills). - skills/setup/adopt.md: when an adopter installs the `pr-management-*` family, inject the same default into their AGENTS.md (conditional on the family being taken; only meaningful with magpie installed locally). - skills/pr-management-code-review/SKILL.md: state explicitly that inline comments are the default/preferred output and body-only is the `inline:off` opt-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Makes
pr-management-code-reviewthe default path for PR code review —both when developing this repo (dogfooding) and for adopters — so reviews
are posted as inline comments anchored to
file:line, presentedindividually for accept/skip, instead of one aggregated summary comment.
The skill already implements the inline-picker-by-default behaviour
(Step 2.6); this change wires it in as the default and states it
explicitly, rather than adding new machinery.
Changes
AGENTS.md— new "Reviewing pull requests" note under Reusableskills: use
pr-management-code-reviewfor reviews in this repo; abody-only review is the explicit
inline:offopt-out, never the default.skills/setup/adopt.md(Step 11.2) — when an adopter installs thepr-management-*family, the setup flow injects the same default intotheir
AGENTS.md(conditional on the family being taken; onlymeaningful with apache-magpie installed locally). Removed on
unadoptwith the rest of the adoption section.
skills/pr-management-code-review/SKILL.md(Step 2.6) — statesinline comments are the default/preferred output and body-only requires
inline:off. No renumbering, so the "Golden rules 7 and 8" refs stay valid.Test plan
skill-and-tool-validate— no HARD failures.skill-evalspytest — 143 pass.